Workaround #10179 in proposal-object-rest-spread #10200
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The real cause of this bug is in
@babel/core
(#10187), but even if we fixed it new versions ofplugin-proposal-object-rest-spread
wouldn't work with older versions of@babel/core
and@babel/helpers
.This bug also needs to be fixed in
@babel/core
anyway, otherwise it will happen again.I couldn't figure out how to add a test for this bug; I tested it manually with a
package.json
like this (it requiresyarn
):Input
Output before the fix
Output after the fix
Note that in the fixed output the injected helper is called
_objectSpread2
only because Babel is trolling* us, that is the_objectSpread
helper present in <7.5.0.*trolling = In the "try" block it genertes an
_objectSpread
UUID which is then discarted, so it must create_objectSpread2
the second time.